Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multiple starts for network setup service. #2512

Merged
merged 4 commits into from
Mar 1, 2022
Merged

fix multiple starts for network setup service. #2512

merged 4 commits into from
Mar 1, 2022

Conversation

nagworld9
Copy link
Contributor

Description

Bug 13092760: fix multiple starts for network setup service.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Feb 15, 2022 •
edited
Loading

Codecov Report

Merging #2512 (bbe3a6c) into develop (dfdf7b4) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head bbe3a6c differs from pull request most recent head 7a2378b. Consider uploading reports for the commit 7a2378b to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2512      +/-   ##
===========================================
- Coverage    71.94%   71.91%   -0.04%     
===========================================
  Files          101      101              
  Lines        15147    15147              
  Branches      2401     2401              
===========================================
- Hits         10898    10893       -5     
- Misses        3771     3773       +2     
- Partials       478      481       +3
Impacted Files Coverage Δ
azurelinuxagent/common/persist_firewall_rules.py 77.71% <100.00%> (ø)
azurelinuxagent/ga/collect_telemetry_events.py 89.72% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdf7b4...7a2378b. Read the comment docs.

@nagworld9 nagworld9 merged commit bb9a337 into Azure:develop Mar 1, 2022
@nagworld9 nagworld9 deleted the BUG-13092760 branch March 1, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinclark19a kevinclark19a kevinclark19a approved these changes

@larohra larohra larohra approved these changes

@narrieta narrieta Awaiting requested review from narrieta narrieta is a code owner

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

@dhivyaganesan dhivyaganesan Awaiting requested review from dhivyaganesan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nagworld9 @kevinclark19a @larohra